Skip to content

fix: checks if paid ticket has payment method enabled #6176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2019
Merged

fix: checks if paid ticket has payment method enabled #6176

merged 3 commits into from
Jul 11, 2019

Conversation

@shreyanshdwivedi
Copy link
Member

@shreyanshdwivedi shreyanshdwivedi commented Jul 11, 2019

Fixes #6169

Short description of what this resolves:

Payment option is not mandatory while creating events, even if the event has paid tickets

Changes proposed in this pull request:

  • Checks for payment method before updating/creating tickets

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the fix label Jul 11, 2019
iamareebjamal
iamareebjamal reviewed Jul 11, 2019
View reviewed changes
iamareebjamal
iamareebjamal reviewed Jul 11, 2019
View reviewed changes
@codecov
Copy link

codecov bot commented Jul 11, 2019 •
edited
Loading

Codecov Report

Merging #6176 into development will decrease coverage by 0.05%.
The diff coverage is 25%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #6176      +/-   ##
===============================================
- Coverage        66.18%   66.13%   -0.06%     
===============================================
  Files              288      288              
  Lines            14460    14479      +19     
===============================================
+ Hits              9571     9575       +4     
- Misses            4889     4904      +15
Impacted Files Coverage Δ
app/api/tickets.py 47.61% <22.22%> (-5.8%) ⬇️
app/models/event.py 79.04% <50%> (-0.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bfa553...34885e7. Read the comment docs.

@fossasia fossasia deleted a comment Jul 11, 2019
@iamareebjamal iamareebjamal merged commit 47f4198 into fossasia:development Jul 11, 2019
@shreyanshdwivedi shreyanshdwivedi deleted the paidTicketCheck branch July 11, 2019 19:57
iamareebjamal pushed a commit to iamareebjamal/open-event-server that referenced this pull request Aug 2, 2019
@shreyanshdwivedi @iamareebjamal
fix: checks if paid ticket has payment method enabled (fossasia#6176)
f1c065b 
* fix: checks if paid ticket has payment method enabled

* introduce is_payment_enabeled function in event model

* updates is_payment_enabled function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

+1 more reviewer

@mrsaicharan1 mrsaicharan1 mrsaicharan1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make payment option mandatory for ogranizer

3 participants

@shreyanshdwivedi @iamareebjamal @mrsaicharan1